apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tushar Gosavi <tus...@datatorrent.com>
Subject Re: JDBC Poller implementation
Date Mon, 08 Aug 2016 12:15:44 GMT
I would prefer a common abstract class having emitTuple method. And
two different implementation one for emitting comma separated values
and other emitting pojo.

Regards,
-Tushar.


On Mon, Aug 8, 2016 at 5:34 PM, Priyanka Gugale
<priyanka@datatorrent.com> wrote:
> The concrete implementation is supposed to do mainly formatting of input
> data and emit in required form. Also it would be tricky to implement some
> abstract methods like "getTuple", you have to conditionally return the
> values.
>
> -Priyanka
>
> On Mon, Aug 8, 2016 at 4:49 PM, Bhupesh Chawda <bhupesh@apache.org> wrote:
>
>> I am +1 for having two ports in the same concrete implementation.
>> One port for POJOs and second one for CSV strings (if this is actually
>> needed)
>>
>> +0 on having multiple concrete operators.
>> I don't think it is necessary to create multiple concrete implementations
>> just because we want the same data in different formats. Ports should serve
>> the purpose.
>>
>> ~ Bhupesh
>>
>>
>> On Mon, Aug 8, 2016 at 4:46 PM, Priyanka Gugale <priyanka@datatorrent.com>
>> wrote:
>>
>> > Hi,
>> >
>> > JDBCPollerInputOperator in malhar repository emits comma separated list
>> of
>> > values as result of scan. As most of our input operators emit POJOs I am
>> > planning to add an implementation which emits pojo.
>> >
>> > I would like to discuss, if we should have two independent jdbc poll
>> input
>> > operators, one emits csv and other which emits pojo or we should have one
>> > operator having two ports?
>> >
>> > I prefer two operators to define clear intent of each operator, but if
>> > anyone has different opinion please suggest.
>> >
>> > -Priyanka
>> >
>>

Mime
View raw message