apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Date Mon, 08 Aug 2016 22:20:15 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r73966670
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableArrayListImpl.java
---
    @@ -0,0 +1,324 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +import java.util.Collection;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.ListIterator;
    +
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.utils.serde.Serde;
    +import org.apache.apex.malhar.lib.utils.serde.SerdeIntSlice;
    +import org.apache.apex.malhar.lib.utils.serde.SerdeListSlice;
    +
    +import com.esotericsoftware.kryo.DefaultSerializer;
    +import com.esotericsoftware.kryo.serializers.FieldSerializer;
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Lists;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * A Spillable implementation of {@link List} backed by a {@link SpillableStateStore}.
    + * @param <T> The type of object stored in the {@link SpillableArrayListImpl}.
    + */
    +@DefaultSerializer(FieldSerializer.class)
    +public class SpillableArrayListImpl<T> implements Spillable.SpillableArrayList<T>,
Spillable.SpillableComponent
    +{
    +  public static final int DEFAULT_BATCH_SIZE = 1000;
    +
    +  private int batchSize = DEFAULT_BATCH_SIZE;
    +  private long bucketId;
    --- End diff --
    
    It seems ```bucketId```, ```prefix``` are unused. Also please add getter/setter for batchsize.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message