apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chaithu14 <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #351: APEXMALHAR-2169 Fixed the issue of dynamic pa...
Date Mon, 08 Aug 2016 05:50:49 GMT
Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/351#discussion_r73824992
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/kafka/AbstractKafkaInputOperator.java
---
    @@ -834,17 +840,16 @@ private boolean isPartitionRequired(int opid, List<KafkaConsumer.KafkaMeterStats
             return false;
           }
     
    +      if (!isPartitionBasedOnLoad) {
    --- End diff --
    
    Consider the below scenario:
    By default, repartitionInterval is 30 sec. So, operator checks whether the repartition
is needed or not at 30, 60, 90, 120, etc. Suppose, Meta-data change happened at 120.
    In this case, operator checks whether repartition required or not at 30, 60, 90 secs.
isPartitionRequired returns true based on HardConstraint and SoftConstraint.
    But, if the user wants to disable the dynamic partition based on load then isPartitionRequied()
has to return false at 30, 60, 90 secs.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message