apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PramodSSImmaneni <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #347: APEXMALHAR-2156 changes
Date Sat, 06 Aug 2016 10:38:19 GMT
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/347#discussion_r73784338
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/kafka/AbstractKafkaInputOperator.java
---
    @@ -250,12 +250,7 @@ public void setup(OperatorContext context)
         consumer.create();
         // reset the offsets to checkpointed one
         if (consumer instanceof SimpleKafkaConsumer && !offsetStats.isEmpty()) {
    -      Map<KafkaPartition, Long> currentOffsets = new HashMap<>();
    -      // Increment the offsets and set it to consumer
    -      for (Map.Entry<KafkaPartition, Long> e: offsetStats.entrySet()) {
    -        currentOffsets.put(e.getKey(), e.getValue() + 1);
    -      }
    -      ((SimpleKafkaConsumer)consumer).resetOffset(currentOffsets);
    +      ((SimpleKafkaConsumer)consumer).resetOffset(offsetStats);
    --- End diff --
    
    Try rebasing your changes on top of latest master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message