apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandeshh <...@git.apache.org>
Subject [GitHub] apex-core pull request #360: APEXCORE-495 supporting apps in config package.
Date Thu, 04 Aug 2016 19:24:03 GMT
Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r73586551
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java ---
    @@ -53,16 +56,16 @@
       private static File configFile;
     
     
    -  private static AppPackage ap;
    -  private static ConfigPackage cp;
    -  static TemporaryFolder testFolder = new TemporaryFolder();
    -  static ApexCli cli = new ApexCli();
    +  private AppPackage ap;
    +  private ConfigPackage cp;
    +  TemporaryFolder testFolder = new TemporaryFolder();
    +  ApexCli cli = new ApexCli();
     
    -  static Map<String, String> env = new HashMap<String, String>();
    -  static String userHome;
    +  Map<String, String> env = new HashMap<String, String>();
    +  String userHome;
     
    -  @BeforeClass
    -  public static void starting()
    +  @Before
    +  public void starting()
    --- End diff --
    
    The merging of the apps deletes the apps from the app-packages. It means that the extracted
packages cannot be reused. So setup needs to be done before every test. I do see some operation
that can be done at class level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message