apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] apex-core pull request #360: APEXCORE-495 supporting apps in config package.
Date Thu, 04 Aug 2016 18:58:13 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r73582496
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java ---
    @@ -126,10 +130,14 @@ public void testLaunchAppPackagePropertyPrecedence() throws Exception
       @Test
       public void testLaunchAppPackageParametersWithConfigPackage() throws Exception
       {
    -    ApexCli.LaunchCommandLineInfo commandLineInfo = ApexCli
    -        .getLaunchCommandLineInfo(new String[]{"-exactMatch", "-conf", configFile.getAbsolutePath(),
appFile.getAbsolutePath(), "MyFirstApplication"});
    +    ApexCli.LaunchCommandLineInfo commandLineInfo =
    +        getLaunchCommandLineInfo(new String[]{"-exactMatch", "-conf", configFile.getAbsolutePath(),
appFile.getAbsolutePath(), "MyFirstApplication"});
    +
    +    commandLineInfo.args = new String[1];
    +    commandLineInfo.args[0] = "MyFirstApplication";
    --- End diff --
    
    Please use the notation `new String[]{ "item1", "item2", ... }` instead of doing element
assignment like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message