apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...
Date Wed, 03 Aug 2016 21:41:45 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/364#discussion_r73426924
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
    @@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
        * @param attributes the value of attributes
        * @param parentContext
        */
    -  public OperatorContext(int id, AttributeMap attributes, Context parentContext)
    +  public OperatorContext(int id, String operatorName, AttributeMap attributes, Context
parentContext)
    --- End diff --
    
    id, name and attributes are public fields on OperatorDeployInfo. Using OperatorDeployInfo
will allow avoiding changes to the OperatorContext constructor each time a new field is introduced.
There seems to be the dependency in production code between OperatorContext and OperatorDeployInfo
anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message