apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...
Date Wed, 03 Aug 2016 21:33:53 GMT
Github user vrozov commented on a diff in the pull request:

    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
    @@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
        * @param attributes the value of attributes
        * @param parentContext
    -  public OperatorContext(int id, AttributeMap attributes, Context parentContext)
    +  public OperatorContext(int id, String operatorName, AttributeMap attributes, Context
         super(attributes, parentContext);
         this.lastProcessedWindowId = Stateless.WINDOW_ID;
         this.id = id;
         this.stateless = super.getValue(OperatorContext.STATELESS);
    +    this.operatorName = Preconditions.checkNotNull(operatorName, "operator name");
    --- End diff --
    Do you mean that LogicalPlan.addOperator() allows empty name? Does not it also allows
`null`? Is there any reason to allow `null` or empty string?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message