apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhupeshchawda <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...
Date Wed, 03 Aug 2016 11:04:47 GMT
Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/358#discussion_r73319381
  
    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
    @@ -51,22 +64,22 @@
     import com.datatorrent.lib.util.KryoCloneUtils;
     import com.datatorrent.netlet.util.DTThrowable;
     
    +import static java.sql.ResultSet.CONCUR_READ_ONLY;
    +import static java.sql.ResultSet.TYPE_FORWARD_ONLY;
    +import static org.jooq.impl.DSL.field;
    +
     /**
      * Abstract operator for for consuming data using JDBC interface<br>
    - * User needs User needs to provide
    - * tableName,dbConnection,setEmitColumnList,look-up key <br>
    - * Optionally batchSize,pollInterval,Look-up key and a where clause can be given
    - * <br>
    + * User needs to provide tableName, dbConnection, columnsExpression, look-up key<br>
    + * Optionally batchSize, pollInterval and a where clause can be given <br>
      * This operator uses static partitioning to arrive at range queries for exactly
      * once reads<br>
      * This operator will create a configured number of non-polling static
      * partitions for fetching the existing data in the table. And an additional
      * single partition for polling additive data. Assumption is that there is an
      * ordered column using which range queries can be formed<br>
    - * If an emitColumnList is provided, please ensure that the keyColumn is the
    + * If an columnsExpression is provided, please ensure that the keyColumn is the
    --- End diff --
    
    If this is a list, better to call it a list, and not an expression


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message