apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] apex-core pull request #364: APEXCORE-448 Made operator name available in op...
Date Wed, 03 Aug 2016 05:17:48 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/364#discussion_r73281978
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
    @@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
        * @param attributes the value of attributes
        * @param parentContext
        */
    -  public OperatorContext(int id, AttributeMap attributes, Context parentContext)
    +  public OperatorContext(int id, String operatorName, AttributeMap attributes, Context
parentContext)
       {
         super(attributes, parentContext);
         this.lastProcessedWindowId = Stateless.WINDOW_ID;
         this.id = id;
         this.stateless = super.getValue(OperatorContext.STATELESS);
    +    this.operatorName = Preconditions.checkNotNull(operatorName, "operator name");
    --- End diff --
    
    I checked locally in an Application test that empty operator name is allowed in the DAG.
I don't think we can restrict it here if adding empty operator name is allowed in the DAG.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message