apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Date Tue, 02 Aug 2016 00:21:01 GMT
Github user chandnisingh commented on a diff in the pull request:

    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableStateStore.java
    @@ -0,0 +1,33 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.state.spillable;
    +import org.apache.apex.malhar.lib.state.BucketedState;
    +import com.datatorrent.api.Component;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Operator;
    +public interface SpillableStateStore extends BucketedState, Component<Context.OperatorContext>,
    --- End diff --
    Maybe I am missing something but please bear with my questions:
    1. Why should a WindowedOperator not have any knowledge of SpillableComponents?
    2. Let's say if above is the case, then what is going to be the API of WindowedOperator
with respect to storage. If WindowedOperator is specifying the contract for a pluggable storage
than an implementation of SpillableStateStore can implement that and therefore can be set
on WindowedOperator. However,  I think SpillableStateStore  itself can be that contract. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message