Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0921200B5B for ; Fri, 1 Jul 2016 03:18:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AF5CC160A52; Fri, 1 Jul 2016 01:18:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0470A160A63 for ; Fri, 1 Jul 2016 03:18:14 +0200 (CEST) Received: (qmail 21092 invoked by uid 500); 1 Jul 2016 01:18:14 -0000 Mailing-List: contact dev-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list dev@apex.apache.org Received: (qmail 21078 invoked by uid 99); 1 Jul 2016 01:18:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 01:18:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9CB12C0591 for ; Fri, 1 Jul 2016 01:18:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NXAV0PUzCkbM for ; Fri, 1 Jul 2016 01:18:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 225475FACC for ; Fri, 1 Jul 2016 01:18:12 +0000 (UTC) Received: (qmail 20650 invoked by uid 99); 1 Jul 2016 01:18:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 01:18:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 752FF2C029F for ; Fri, 1 Jul 2016 01:18:11 +0000 (UTC) Date: Fri, 1 Jul 2016 01:18:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Jul 2016 01:18:15 -0000 [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D15358193#comment-15358193 ]=20 ASF GitHub Bot commented on APEXMALHAR-2069: -------------------------------------------- GitHub user sanjaypujare reopened a pull request: https://github.com/apache/apex-malhar/pull/329 Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vro= =E2=80=A6 @vrozov pls review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sanjaypujare/apex-malhar master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/apex-malhar/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 =20 ---- commit beb394bbd5d136ccc49ed9ac4da060066ad59252 Author: Sanjay Pujare Date: 2016-06-30T01:08:30Z Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vrozo= v pls review commit 919fdfca2886a45c42e747283ee75d7243c5c3ff Author: Sanjay Pujare Date: 2016-07-01T01:05:07Z Fix for APEXMALHAR-2069: throw a RuntimeException if scanService is alr= eady set, fix unit tests to call setup only on WindowDataManager ---- > FileSplitterInput and TimeBasedDirectoryScanner - move operational fields= initialization from constructor to setup > -------------------------------------------------------------------------= ----------------------------------------- > > Key: APEXMALHAR-2069 > URL: https://issues.apache.org/jira/browse/APEXMALHAR-206= 9 > Project: Apache Apex Malhar > Issue Type: Improvement > Reporter: Vlad Rozov > > For example, there is no need for scanService to be initialized in the co= nstructor. It should be done during operator setup(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)