Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: tweise <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-362-apex-core@git.apache.org>
In-Reply-To: <git-pr-362-apex-core@git.apache.org>
Subject: [GitHub] apex-core pull request #362: APEXCORE-494 Fixed the dynamic partition issue ...
Content-Type: text/plain
Message-Id: <20160730194329.251F3E1892@git1-us-west.apache.org>
Date: Sat, 30 Jul 2016 19:43:29 +0000 (UTC)
archived-at: Sat, 30 Jul 2016 19:43:33 -0000

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/362#discussion_r72893138
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
    @@ -962,8 +963,11 @@ private void redoPartitions(PMapping currentMapping, String note)
           mainPC.operatorIdToPartition.put(p.getId(), newPartition);
         }
     
    +    // Get the deepest down stream mapping
    +    PMapping downStreamMapping = currentMapping;
    --- End diff --
    
    What means "deepest"? There could be multiple such mappings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---