Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-357-apex-core@git.apache.org>
In-Reply-To: <git-pr-357-apex-core@git.apache.org>
Subject: [GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...
Content-Type: text/plain
Message-Id: <20160714173324.0CE6BE383A@git1-us-west.apache.org>
Date: Thu, 14 Jul 2016 17:33:24 +0000 (UTC)
archived-at: Thu, 14 Jul 2016 17:33:28 -0000

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/357#discussion_r70848037
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java ---
    @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration conf)
         return principal;
       }
     
    -  public static String getSchemePrefix(YarnConfiguration conf)
    +  public static boolean isSSLEnabled(Configuration conf)
    +  {
    +    if (HttpConfig.Policy.HTTPS_ONLY == HttpConfig.Policy.fromString(
    +        conf.get(YarnConfiguration.YARN_HTTP_POLICY_KEY, YarnConfiguration.YARN_HTTP_POLICY_DEFAULT))) {
    +      return true;
    +    }
    +    return false;
    +  }
    +
    +  public static String getSchemePrefix(Configuration conf)
       {
    -    if (HttpConfig.Policy.HTTPS_ONLY == HttpConfig.Policy.fromString(conf.get(YarnConfiguration.YARN_HTTP_POLICY_KEY, YarnConfiguration.YARN_HTTP_POLICY_DEFAULT))) {
    +    if (isSSLEnabled(conf)) {
    --- End diff --
    
    I think @vrozov also pointed out this earlier, but this function is not required.. I see all the usages passing Yarnconfiguration


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---