Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-357-apex-core@git.apache.org>
In-Reply-To: <git-pr-357-apex-core@git.apache.org>
Subject: [GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...
Content-Type: text/plain
Message-Id: <20160713235500.4C771E04BE@git1-us-west.apache.org>
Date: Wed, 13 Jul 2016 23:55:00 +0000 (UTC)
archived-at: Wed, 13 Jul 2016 23:55:09 -0000

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/357#discussion_r70728942
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -614,7 +615,16 @@ protected void serviceStart() throws Exception
           }
           WebApp webApp = WebApps.$for("stram", StramAppContext.class, appContext, "ws").with(config).start(new StramWebApp(this.dnmgr));
           LOG.info("Started web service at port: " + webApp.port());
    -      this.appMasterTrackingUrl = NetUtils.getConnectAddress(webApp.getListenerAddress()).getHostName() + ":" + webApp.port();
    +      String host = NetUtils.getConnectAddress(webApp.getListenerAddress()).getHostName() + ":" + webApp.port();
    +
    +      // For backward compatibility, not adding scheme in TrackingURL for non-HTTPS
    +      // TODO: Remove the check in next major release and add scheme always
    +      if (ConfigUtils.isSSLEnabled(config)) {
    +        String scheme = ConfigUtils.getSchemePrefix(config);
    --- End diff --
    
    why do you need to make `ConfigUtils.getSchemePrefix` call? If `ConfigUtils.isSSLEnabled == true` then scheme is always https://..
    
    Why not have `this.appMasterTrackingUrl = ConfigUtils.getSchemePrefix(config) + host` instead of `if-else` loop?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---