apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2156) JMS Input operator enhancements
Date Tue, 26 Jul 2016 21:52:20 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394611#comment-15394611
] 

ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------

Github user sanjaypujare commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/347#discussion_r72344786
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
    @@ -355,10 +366,13 @@ public void createConnection() throws JMSException
        */
       protected ConnectionFactory getConnectionFactory()
       {
    -    logger.debug("class {} properties {}", connectionFactoryClass, connectionFactoryProperties);
    +    logger.debug("connectionFactoryBuilder {} connectionFactoryClass {} properties {}",
"" + connectionFactoryBuilder,
    +        connectionFactoryClass, connectionFactoryProperties);
         ConnectionFactory cf;
         try {
    -      if (connectionFactoryClass != null) {
    +      if (connectionFactoryBuilder != null) {
    +        cf = connectionFactoryBuilder.buildConnectionFactory();
    +      } else if (connectionFactoryClass != null) {
    --- End diff --
    
    Yes, both valid points. But both the default class (ActiveMQConnectionFactory) and connection
factory properties was old code. Let's see if this should be changed under a separate JIRA



> JMS Input operator enhancements
> -------------------------------
>
>                 Key: APEXMALHAR-2156
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Sanjay M Pujare
>            Assignee: Sanjay M Pujare
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> This is described in https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message