apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup
Date Thu, 07 Jul 2016 00:35:11 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365394#comment-15365394
] 

ASF GitHub Bot commented on APEXMALHAR-2069:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/333#discussion_r69835747
  
    --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
    @@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator() throws InterruptedException
         testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
     
     
    -    testMeta.fileSplitterInput.setup(testMeta.context);
    --- End diff --
    
    It's not a point.  It's a question.  I am asking if similar changes are going to be made
throughout the codebase?  
    To me this change is completely  unnecessary. IMO code which was clean and intuitive is
made the opposite just because a handful of unused objects will be present in stram. 
    



> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization
from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2069
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Sanjay M Pujare
>             Fix For: 3.5.0
>
>
> For example, there is no need for scanService to be initialized in the constructor. It
should be done during operator setup().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message