apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup
Date Wed, 06 Jul 2016 00:01:28 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363503#comment-15363503
] 

ASF GitHub Bot commented on APEXMALHAR-2069:
--------------------------------------------

GitHub user sanjaypujare opened a pull request:

    https://github.com/apache/apex-malhar/pull/333

    Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vro…

    @vrozov  pls review
    
    		: throw a RuntimeException if scanService is already set, fix unit tests to call setup
only on WindowDataManager
    		: move the initialization of most data members from the constructor to setup for the
TimeBasedDirectoryScanner class
    		: move the initialization of most data members from the ctor to setup for FileSplitterInput
class

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaypujare/apex-malhar APEXMALHAR-2069.improvement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/333.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #333
    
----
commit ccbc50e67832eeb66bffe147cede486c9f1d5b9c
Author: Sanjay Pujare <sanjaypujare@sanjay-dt-macbook-pro.local>
Date:   2016-06-30T01:08:30Z

    Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vrozov pls review
    		: throw a RuntimeException if scanService is already set, fix unit tests to call setup
only on WindowDataManager
    		: move the initialization of most data members from the constructor to setup for the
TimeBasedDirectoryScanner class
    		: move the initialization of most data members from the ctor to setup for FileSplitterInput
class

----


> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization
from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2069
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>
> For example, there is no need for scanService to be initialized in the constructor. It
should be done during operator setup().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message