apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Date Thu, 28 Jul 2016 16:28:07 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r72655301
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableByteMapImpl.java
---
    @@ -0,0 +1,210 @@
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +import java.util.Collection;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.state.BucketedState;
    +import org.apache.apex.malhar.lib.utils.serde.Serde;
    +import org.apache.apex.malhar.lib.utils.serde.SliceUtils;
    +import org.apache.commons.lang3.ArrayUtils;
    +import org.apache.commons.lang3.mutable.MutableInt;
    +
    +import com.google.common.base.Preconditions;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.netlet.util.Slice;
    +
    +public class SpillableByteMapImpl<K, V> implements Spillable.SpillableByteMap<K,
V>, Spillable.SpillableComponent
    +{
    +  @NotNull
    +  private SpillableStateStore store;
    +  @NotNull
    +  private byte[] identifier;
    +  private long bucket;
    +  @NotNull
    +  private Serde<K, Slice> serdeKey;
    +  @NotNull
    +  private Serde<V, Slice> serdeValue;
    +
    +  private int size = 0;
    +
    +  private transient WindowBoundedMapCache<K, V> cache = new WindowBoundedMapCache<>();
    --- End diff --
    
    good catch @brightchenSpillableByteArrayListMultimapImpl.cache should be transient


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message