apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Date Mon, 25 Jul 2016 19:04:15 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r72124180
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableByteArrayListMultimapImpl.java
---
    @@ -0,0 +1,262 @@
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import javax.annotation.Nullable;
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.utils.serde.PassThruByteArraySliceSerde;
    +import org.apache.apex.malhar.lib.utils.serde.Serde;
    +import org.apache.apex.malhar.lib.utils.serde.SerdeIntSlice;
    +import org.apache.apex.malhar.lib.utils.serde.SliceUtils;
    +
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Multimap;
    +import com.google.common.collect.Multiset;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * Created by tfarkas on 6/12/16.
    + */
    +public class SpillableByteArrayListMultimapImpl<K, V> implements Spillable.SpillableByteArrayListMultimap<K,
V>,
    +    Spillable.SpillableComponent
    +{
    +  public static final int DEFAULT_BATCH_SIZE = 1000;
    +  public static final byte[] SIZE_KEY_SUFFIX = new byte[]{(byte)0, (byte)0, (byte)0};
    +
    +  private int batchSize = DEFAULT_BATCH_SIZE;
    +
    +  private WindowBoundedMapCache<K, SpillableArrayListImpl<V>> cache = new
WindowBoundedMapCache<>();
    +
    +  @NotNull
    +  private SpillableByteMapImpl<byte[], Integer> map;
    +
    +  private SpillableStateStore store;
    +  private byte[] identifier;
    +  private long bucket;
    +  private Serde<K, Slice> serdeKey;
    +  private Serde<V, Slice> serdeValue;
    +
    +  private boolean isRunning = false;
    +  private boolean isInWindow = false;
    +
    +  public SpillableByteArrayListMultimapImpl(SpillableStateStore store, byte[] identifier,
long bucket,
    +      Serde<K, Slice> serdeKey,
    +      Serde<V, Slice> serdeValue)
    +  {
    +    this.store = Preconditions.checkNotNull(store);
    +    this.identifier = Preconditions.checkNotNull(identifier);
    +    this.bucket = bucket;
    +    this.serdeKey = Preconditions.checkNotNull(serdeKey);
    +    this.serdeValue = Preconditions.checkNotNull(serdeValue);
    +
    +    map = new SpillableByteMapImpl(store, identifier, bucket, new PassThruByteArraySliceSerde(),
new SerdeIntSlice());
    --- End diff --
    
    No it shouldn't. That error existed before but I fixed it with my latest commits. Do you
have the latest? If so I'll check tonight to see if I can reproduce it in my tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message