apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #322: APEXMALHAR-2063 Made window data manager use ...
Date Sun, 24 Jul 2016 21:05:44 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/322#discussion_r71995534
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/wal/WindowDataManager.java
---
    @@ -126,36 +146,24 @@ public void teardown()
         }
     
         @Override
    -    public void save(Object object, int operatorId, long windowId) throws IOException
    +    public void save(Object object, long windowId) throws IOException
         {
         }
     
         @Override
    -    public Object load(int operatorId, long windowId) throws IOException
    +    public Object retrieve(long windowId) throws IOException
         {
           return null;
         }
     
         @Override
    -    public void delete(int operatorId, long windowId) throws IOException
    -    {
    -    }
    -
    -    @Override
    -    public void deleteUpTo(int operatorId, long windowId) throws IOException
    --- End diff --
    
    changed the method to be committed(long windowId). WindowDataManager is Evolving so this
was ok. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message