apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] apex-core pull request #359: APEXCORE-494 Fixed the dynamic partition issue ...
Date Thu, 21 Jul 2016 22:47:24 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/359#discussion_r71801328
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
    @@ -895,8 +895,10 @@ private void redoPartitions(PMapping currentMapping, String note)
             addedPartitions.add(newPartition);
           } else {
             // check whether mapping was changed
    +        int currentPartitionsSize = mainPC.currentPartitions.size();
             for (DefaultPartition<Operator> pi : mainPC.currentPartitions) {
    -          if (pi == newPartition && pi.isModified()) {
    +          if (pi == newPartition && (pi.isModified() ||
    --- End diff --
    
    @tweise Should not redeploy of downstream being done only when downstream pipeline has
a unifier and only unifier needs to be redeployed for the pipeline connected to the current
partition? For example, if logical dag is defined as:
    ```
    A->B-C->Aggregator
    ```
    and it is partitioned to 2 pipelines starting with A:
    ```
    A1->B1->C1->
                 U->Aggregator
    A2->B2->C2->
    ```
    and A is repartitioned to 3:
    ```
    A1->B1->C1->
    A2->B2->C2->U->Aggregator
    A3->B3->C3->
    ```
    A1->B1->C1 and A2->B2->C2 don't need to be redeploed? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message