apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] apex-core pull request #359: APEXCORE-494 Fixed the dynamic partition issue ...
Date Thu, 21 Jul 2016 16:57:10 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/359#discussion_r71744011
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
    @@ -895,8 +895,10 @@ private void redoPartitions(PMapping currentMapping, String note)
             addedPartitions.add(newPartition);
           } else {
             // check whether mapping was changed
    +        int currentPartitionsSize = mainPC.currentPartitions.size();
             for (DefaultPartition<Operator> pi : mainPC.currentPartitions) {
    -          if (pi == newPartition && pi.isModified()) {
    +          if (pi == newPartition && (pi.isModified() ||
    --- End diff --
    
    How that is different from a case when current partition size is 2 and new partition size
is 3 or more and it includes 2 current partitions? Is the behavior different because there
were no unifiers? But unifiers may never come into the picture or be introduced several operators
downstream. The problem seems to be in the definePartitions() that returns the current partition.
I may be wrong, but I don't see why it is necessary to handle current partition size equal
to one differently in the modified code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message