apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] apex-core pull request #350: APEXCORE-222 Purging the stale data present in ...
Date Fri, 15 Jul 2016 16:59:41 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r71005395
  
    --- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java
---
    @@ -176,21 +176,20 @@ public void reset()
         numberOfInMemBlockPermits.set(MAX_COUNT_OF_INMEM_BLOCKS - 1);
       }
     
    -  public void purge(final int baseSeconds, final int windowId)
    +  public void purge(long windowId)
    --- End diff --
    
    should windowId be made final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message