apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pradeepdalvi <...@git.apache.org>
Subject [GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...
Date Tue, 12 Jul 2016 20:33:44 GMT
Github user pradeepdalvi commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/357#discussion_r70516680
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -608,13 +609,16 @@ protected void serviceStart() throws Exception
     
         try {
           Configuration config = getConfig();
    +      YarnConfiguration conf = new YarnConfiguration();
    --- End diff --
    
    Configuration is needed by WebApp server. We could probably do something like `YarnConfiguration
conf = StramClientUtils.getYarnConfiguration(config);`
    or
    `YarnConfiguration conf = new YarnConfiguration(config);`
    However in both cases there is not much significant difference unless & until config
is instanceof YarnConfiguration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message