apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandeshh <...@git.apache.org>
Subject [GitHub] apex-core pull request #357: APEXCORE-488: Issues in SSL communication with ...
Date Mon, 11 Jul 2016 23:27:44 GMT
Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/357#discussion_r70355340
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/StramAgent.java ---
    @@ -204,7 +204,14 @@ private UriBuilder getStramWebURIBuilder(WebServicesClient webServicesClient,
St
         if (info != null) {
           //ws = wsClient.resource("http://" + info.appMasterTrackingUrl).path(WebServices.PATH).path(info.version).path("stram");
           // the filter should convert to the right version
    -      ub = UriBuilder.fromUri("http://" + info.appMasterTrackingUrl).path(WebServices.PATH).path(WebServices.VERSION).path("stram");
    +      String url;
    +      if (!info.appMasterTrackingUrl.startsWith("http://")
    +          && !info.appMasterTrackingUrl.startsWith("https://")) {
    +        url = "http://" + info.appMasterTrackingUrl;
    --- End diff --
    
    It should be logged, saying falling back to http


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message