apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...
Date Thu, 07 Jul 2016 18:33:19 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/351#discussion_r69961409
  
    --- Diff: api/src/main/java/com/datatorrent/api/ClusterMode.java ---
    @@ -0,0 +1,67 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.api;
    +
    +import org.apache.hadoop.conf.Configuration;
    +
    +/**
    + *
    + */
    +public abstract class ClusterMode<H extends Launcher.AppHandle> extends Launcher<H>
    +{
    +
    +  public static final Attribute<String> LIB_JARS = new Attribute<String>(new
StringCodec.String2String());
    +  public static final Attribute<String> ORIGINAL_APP_ID = new Attribute<String>(new
StringCodec.String2String());
    +  public static final Attribute<String> QUEUE_NAME = new Attribute<String>(new
StringCodec.String2String());
    --- End diff --
    
    @PramodSSImmaneni : I have following feedback on this
    1. Attribute is used to define variables that control Platform behavior. These defined
here don't control platform behavior
    2. When user launches app using cli, user can pass these as command line options but they
are not set as attributes but now with cluster mode implementation you are asking user to
set them as attributes. There is discrepancy here.
    3. Using cli, user can also set more options which is not reflected in this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message