apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #333: Fix for APEXMALHAR-2069: moved creation of sc...
Date Thu, 07 Jul 2016 01:44:20 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/333#discussion_r69840635
  
    --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
    @@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator() throws InterruptedException
         testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
     
     
    -    testMeta.fileSplitterInput.setup(testMeta.context);
    --- End diff --
    
    @chandnisingh I already looked at the test during PRs #329 and #333 review. The modified
code is clean and readable as well as the original code. The only problem in the original
operator code was a wrong time of resource allocation/initialization that is now fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message