apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #333: Fix for APEXMALHAR-2069: moved creation of sc...
Date Thu, 07 Jul 2016 01:15:31 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/333#discussion_r69838659
  
    --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
    @@ -499,7 +499,7 @@ public void testRecoveryOfBlockMetadataIterator() throws InterruptedException
         testMeta.fileSplitterInput.getScanner().setScanIntervalMillis(500);
     
     
    -    testMeta.fileSplitterInput.setup(testMeta.context);
    --- End diff --
    
    @vrozov 
    Please take a look at the tests.  They are validating what they are supposed to. 
    Well IMO cleaner and intuitive code is much more important. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message