apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...
Date Wed, 06 Jul 2016 23:26:47 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/351#discussion_r69829746
  
    --- Diff: api/src/main/java/com/datatorrent/api/LocalMode.java ---
    @@ -125,9 +137,13 @@ public static void runApp(StreamingApplication app, int runMillis)
       public static void runApp(StreamingApplication app, Configuration configuration, int
runMillis)
       {
         LocalMode lma = newInstance();
    -    app.populateDAG(lma.getDAG(), configuration == null ? new Configuration(false) :
configuration);
    -    LocalMode.Controller lc = lma.getController();
    -    lc.run(runMillis);
    +    Attribute.AttributeMap launchAttributes = new Attribute.AttributeMap.DefaultAttributeMap();
    +    launchAttributes.put(RUN_MILLIS, (long)runMillis);
    +    try {
    +      lma.launchApp(app, configuration, launchAttributes);
    +    } catch (LaunchException e) {
    +      DTThrowable.rethrow(e);
    --- End diff --
    
    DTThowable has been deprecated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message