apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] apex-core pull request #351: APEXCORE-405 Common API to launch on local mode...
Date Fri, 01 Jul 2016 10:30:45 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/351#discussion_r69280615
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/LocalModeImpl.java ---
    @@ -54,6 +55,53 @@ public DAG cloneDAG() throws Exception
       }
     
       @Override
    +  public LocalAppHandle launchApp(StreamingApplication application, Configuration configuration,
Attribute.AttributeMap
    +      launchAttributes) throws LaunchException
    +  {
    +    try {
    +      //application.populateDAG(getDAG(), configuration == null ? new Configuration(false)
: configuration);
    --- End diff --
    
    remove commented code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message