Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EDF86200B2B for ; Tue, 14 Jun 2016 00:06:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC8E0160A3C; Mon, 13 Jun 2016 22:06:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EBC6160A5B for ; Tue, 14 Jun 2016 00:06:08 +0200 (CEST) Received: (qmail 55912 invoked by uid 500); 13 Jun 2016 22:06:07 -0000 Mailing-List: contact dev-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list dev@apex.apache.org Received: (qmail 55901 invoked by uid 99); 13 Jun 2016 22:06:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 22:06:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DD925C0713 for ; Mon, 13 Jun 2016 22:06:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RiCYjcagjdj4 for ; Mon, 13 Jun 2016 22:06:06 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 234875F2F2 for ; Mon, 13 Jun 2016 22:06:04 +0000 (UTC) Received: (qmail 55668 invoked by uid 99); 13 Jun 2016 22:06:04 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 22:06:04 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D79ED2C1F61 for ; Mon, 13 Jun 2016 22:06:03 +0000 (UTC) Date: Mon, 13 Jun 2016 22:06:03 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXMALHAR-2117) JDBCLoader for Enricher should generate default queryStmt even when value is empty string MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Jun 2016 22:06:09 -0000 [ https://issues.apache.org/jira/browse/APEXMALHAR-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328402#comment-15328402 ] ASF GitHub Bot commented on APEXMALHAR-2117: -------------------------------------------- GitHub user chinmaykolhatkar opened a pull request: https://github.com/apache/apex-malhar/pull/317 APEXMALHAR-2117 Generate default queryStmt even if its set to empty string Also added missing hsqldb mavne dependency for test scope. @sandeepdeshmukh Can you please review and merge? You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinmaykolhatkar/apex-malhar APEXMALHAR-2117 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/apex-malhar/pull/317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #317 ---- commit 882e4568a0176723cdc31de4eef021f6376b2c6c Author: Chinmay Kolhatkar Date: 2016-06-13T22:02:01Z APEXMALHAR-2117 Generate default queryStmt even if its set to empty string. Also added missing hsqldb mavne dependency for test scope. ---- > JDBCLoader for Enricher should generate default queryStmt even when value is empty string > ------------------------------------------------------------------------------------------ > > Key: APEXMALHAR-2117 > URL: https://issues.apache.org/jira/browse/APEXMALHAR-2117 > Project: Apache Apex Malhar > Issue Type: Bug > Components: utilities > Affects Versions: 3.4.0 > Reporter: Chinmay Kolhatkar > Assignee: Chinmay Kolhatkar > > Currently JDBCLoader creates a default queryStmt based on properties set only when the queryStmt is set to null. > It should do that same when its set to empty string. -- This message was sent by Atlassian JIRA (v6.3.4#6332)