Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 83903200B29 for ; Thu, 30 Jun 2016 20:00:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 82483160A06; Thu, 30 Jun 2016 18:00:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3D0B160A63 for ; Thu, 30 Jun 2016 20:00:18 +0200 (CEST) Received: (qmail 16163 invoked by uid 500); 30 Jun 2016 18:00:17 -0000 Mailing-List: contact dev-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list dev@apex.apache.org Received: (qmail 16029 invoked by uid 99); 30 Jun 2016 18:00:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2016 18:00:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CF405C02E8 for ; Thu, 30 Jun 2016 18:00:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nywPGsq9taDX for ; Thu, 30 Jun 2016 18:00:16 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id C106B5FB20 for ; Thu, 30 Jun 2016 18:00:15 +0000 (UTC) Received: (qmail 13105 invoked by uid 99); 30 Jun 2016 18:00:15 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2016 18:00:15 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0083E2C02A6 for ; Thu, 30 Jun 2016 18:00:15 +0000 (UTC) Date: Thu, 30 Jun 2016 18:00:15 +0000 (UTC) From: "Munagala V. Ramanath (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Jun 2016 18:00:19 -0000 [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357572#comment-15357572 ] Munagala V. Ramanath commented on APEXMALHAR-2069: -------------------------------------------------- The issue may be because in the unit test, fileSplitterInput is being created just once in the starting() function but setup() is being invoked on it in multiple places. > FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup > ------------------------------------------------------------------------------------------------------------------ > > Key: APEXMALHAR-2069 > URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069 > Project: Apache Apex Malhar > Issue Type: Improvement > Reporter: Vlad Rozov > > For example, there is no need for scanService to be initialized in the constructor. It should be done during operator setup(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)