Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
Date: Thu, 23 Jun 2016 11:49:16 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12956139.1459859608000.9106.1466682556250@Atlassian.JIRA>
In-Reply-To: <JIRA.12956139.1459859608000@Atlassian.JIRA>
References: <JIRA.12956139.1459859608000@Atlassian.JIRA> <JIRA.12956139.1459859608188@arcas>
Subject: [jira] [Commented] (APEXMALHAR-2045) Add bandwidth control feature
 to Apex
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 23 Jun 2016 11:49:20 -0000


    [ https://issues.apache.org/jira/browse/APEXMALHAR-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346308#comment-15346308 ] 

ASF GitHub Bot commented on APEXMALHAR-2045:
--------------------------------------------

Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/279#discussion_r68220624
  
    --- Diff: library/src/test/java/com/datatorrent/lib/bandwidth/BandwidthManagerTest.java ---
    @@ -0,0 +1,150 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package com.datatorrent.lib.bandwidth;
    +
    +import java.io.File;
    +import java.io.IOException;
    +
    +import org.junit.Assert;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TestWatcher;
    +import org.junit.runner.Description;
    +import org.apache.commons.io.FileUtils;
    +
    +import com.datatorrent.api.Attribute;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DAG;
    +import com.datatorrent.lib.helper.OperatorContextTestHelper;
    +
    +public class BandwidthManagerTest
    +{
    +  private static class TestMeta extends TestWatcher
    +  {
    +    private String applicationPath;
    +    private BandwidthManager underTest;
    +    private Context.OperatorContext context;
    +    private long bandwidthLimit = 10L;
    +    private ScheduledExecutorTestService mockschedular;
    --- End diff --
    
    I am getting some rat check errors, so moving back the class to it's own file. Can we leave it this way? Having around 90 lines of class as annonymous class won't be readable code.


> Add bandwidth control feature to Apex
> -------------------------------------
>
>                 Key: APEXMALHAR-2045
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2045
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
>  bandwidth restrictions on input operator for number of bytes to be consumed per second.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)