Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: vrozov <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-350-apex-core@git.apache.org>
In-Reply-To: <git-pr-350-apex-core@git.apache.org>
Subject: [GitHub] apex-core pull request #350: APEXCORE-222 Purging the stale data present in ...
Content-Type: text/plain
Message-Id: <20160623021706.046FADFEDA@git1-us-west.apache.org>
Date: Thu, 23 Jun 2016 02:17:06 +0000 (UTC)
archived-at: Thu, 23 Jun 2016 02:17:10 -0000

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r68166717
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -769,7 +769,11 @@ public void processHeartbeatResponse(ContainerHeartbeatResponse rsp)
         }
     
         if (rsp.committedWindowId != lastCommittedWindowId) {
    +
           lastCommittedWindowId = rsp.committedWindowId;
    +
    +      bufferServer.purge(lastCommittedWindowId);
    --- End diff --
    
    In StreamingContainerManager windowId to purge is decremented by 1. Please check if the same decrement needs to be applied here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---