Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: brightchen <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-321-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-321-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #321: APEXMALHAR-2120 #resolve #comment solve probl...
Content-Type: text/plain
Message-Id: <20160620222217.2418DDFC6F@git1-us-west.apache.org>
Date: Mon, 20 Jun 2016 22:22:17 +0000 (UTC)
archived-at: Mon, 20 Jun 2016 22:22:23 -0000

Github user brightchen commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/321#discussion_r67777812
  
    --- Diff: kafka/src/test/java/org/apache/apex/malhar/kafka/KafkaInputOperatorTest.java ---
    @@ -68,26 +70,53 @@
     
       public static String APPLICATION_PATH = baseDir + File.separator + StramLocalCluster.class.getName() + File.separator;
     
    +  public class KafkaTestInfo extends TestWatcher
    +  {
    +    public org.junit.runner.Description desc;
    +
    +    public String getDir()
    +    {
    +      String methodName = desc.getMethodName();
    +      String className = desc.getClassName();
    +      return "target/" + className + "/" + methodName + "/" + testName;
    +    }
    +
    +    @Override
    +    protected void starting(org.junit.runner.Description description)
    +    {
    +      this.desc = description;
    +    }
    +  }
    +  
    +  @Rule
    +  public final KafkaTestInfo testInfo = new KafkaTestInfo();
    +  
    +  
       @Parameterized.Parameters(name = "multi-cluster: {0}, multi-partition: {1}, partition: {2}")
       public static Collection<Object[]> testScenario()
       {
    -    return Arrays.asList(new Object[][]{{true, false, "one_to_one"},// multi cluster with single partition
    +    return Arrays.asList(new Object[][]{
    +      {true, false, "one_to_one"},// multi cluster with single partition
           {true, false, "one_to_many"},
           {true, true, "one_to_one"},// multi cluster with multi partitions
    -      {true, true, "one_to_many"},
    +      {true, true, "one_to_many"},   //test failed, no data received.
    --- End diff --
    
    Yes, I'll remove the comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---