Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: brennonyork <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-315-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-315-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #315: [APEXMALHAR-2102] Support clone partitioner
Content-Type: text/plain
Message-Id: <20160608215430.D5EB6E69BE@git1-us-west.apache.org>
Date: Wed,  8 Jun 2016 21:54:30 +0000 (UTC)
archived-at: Wed, 08 Jun 2016 21:54:35 -0000

Github user brennonyork commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/315#discussion_r66347754
  
    --- Diff: library/src/main/java/com/datatorrent/lib/partitioner/ClonePartitioner.java ---
    @@ -0,0 +1,143 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.partitioner;
    +
    +import java.io.Serializable;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import javax.validation.constraints.Min;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Sets;
    +
    +import com.datatorrent.api.DefaultPartition;
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.api.Operator.InputPort;
    +import com.datatorrent.api.Partitioner;
    +
    +/**
    + * This is a simple partitioner, which replicates data across all partitions of an operator.
    + *
    + * @param <T> The type of the operator
    + * @since 2.0.0
    + */
    +public class ClonePartitioner<T extends Operator> implements Partitioner<T>, Serializable
    +{
    +  private static final Logger logger = LoggerFactory.getLogger(ClonePartitioner.class);
    +  
    +  private static final long serialVersionUID = 201462371710L;
    +  /**
    +   * The number of partitions for the default partitioner to create.
    +   */
    +  @Min(1)
    +  private int partitionCount = 1;
    +
    +  /**
    +   * This creates a partitioner which creates only one partition.
    +   */
    +  public ClonePartitioner()
    +  {
    +  }
    +
    +  /**
    +   * This constructor is used to create the partitioner from a property.
    +   * @param value A string which is an integer of the number of partitions to create
    +   */
    +  public ClonePartitioner(String value)
    +  {
    +    this(Integer.parseInt(value));
    +  }
    +
    +  /**
    +   * This creates a partitioner which creates partitonCount partitions.
    +   * @param partitionCount The number of partitions to create.
    +   */
    +  public ClonePartitioner(int partitionCount)
    +  {
    +    this.partitionCount = partitionCount;
    +  }
    +
    +  /**
    +   * This method sets the number of partitions for the ClonePartitioner to create.
    +   * @param partitionCount The number of partitions to create.
    +   */
    +  public void setPartitionCount(int partitionCount)
    +  {
    +    this.partitionCount = partitionCount;
    +  }
    +
    +  /**
    +   * This method gets the number of partitions for the ClonePartitioner to create.
    +   * @return The number of partitions to create.
    +   */
    +  public int getPartitionCount()
    +  {
    +    return partitionCount;
    +  }
    +
    +  @Override
    +  public Collection<Partition<T>> definePartitions(Collection<Partition<T>> partitions, PartitioningContext context)
    +  {
    +    final int newPartitionCount = DefaultPartition.getRequiredPartitionCount(context, this.partitionCount);
    +    logger.debug("define partitions, partitionCount current {} requested {}", partitions.size(), newPartitionCount);
    +
    +    //Get a partition
    +    DefaultPartition<T> partition = (DefaultPartition<T>)partitions.iterator().next();
    +    ArrayList<Partition<T>> newPartitions;
    --- End diff --
    
    why not `ArrayList<Partition<T>> newPartitions = Lists.newArrayList();` and remove line 112?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---