Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: chinmaykolhatkar <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-298-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-298-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #298: *For review only* [APEXMALHAR-2086] Kafka out...
Content-Type: text/plain
Message-Id: <20160607185612.D4211DFC61@git1-us-west.apache.org>
Date: Tue,  7 Jun 2016 18:56:12 +0000 (UTC)
archived-at: Tue, 07 Jun 2016 18:56:18 -0000

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/298#discussion_r66131514
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaOutputOperator.java ---
    @@ -0,0 +1,141 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.apex.malhar.kafka;
    +
    +import java.util.Properties;
    +import javax.validation.constraints.NotNull;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import org.apache.commons.lang3.StringUtils;
    +import org.apache.kafka.clients.producer.KafkaProducer;
    +import org.apache.kafka.clients.producer.Producer;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Operator;
    +
    +public abstract class AbstractKafkaOutputOperator<K, V> implements Operator
    +{
    +  @SuppressWarnings("unused")
    +  private static final Logger logger = LoggerFactory.getLogger(AbstractKafkaOutputOperator.class);
    +  private transient Producer<K, V> producer;  // K is key partitioner, V is value type
    +  @NotNull
    +  private String topic = "topic1";
    +  private String producerProperties = "";
    +  private Properties configProperties = new Properties();
    +  public Properties getConfigProperties()
    +  {
    +    return configProperties;
    +  }
    +
    +  public void setConfigProperties(Properties configProperties)
    +  {
    +    this.configProperties.putAll(configProperties);
    +  }
    +
    +  /**
    +   * setup producer configuration.
    +   * @return ProducerConfig
    +   */
    +  protected Properties createKafkaProducerConfig()
    +  {
    +    Properties prop = new Properties();
    +    for (String propString : producerProperties.split(",")) {
    +      if (!propString.contains("=")) {
    +        continue;
    +      }
    +      String[] keyVal = StringUtils.trim(propString).split("=");
    +      prop.put(StringUtils.trim(keyVal[0]), StringUtils.trim(keyVal[1]));
    +    }
    +
    +    configProperties.putAll(prop);
    +
    +    return configProperties;
    +  }
    +
    +  public Producer<K, V> getProducer()
    --- End diff --
    
    Any reason why this is made public? Its being accessed from subclass.. So can be made protected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---