Return-Path: <dev-return-11937-archive-asf-public=cust-asf.ponee.io@apex.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 4DC35200B14
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat,  4 Jun 2016 01:14:24 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 4CB66160A50; Fri,  3 Jun 2016 23:14:24 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9222C160A49
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  4 Jun 2016 01:14:23 +0200 (CEST)
Received: (qmail 77053 invoked by uid 500); 3 Jun 2016 23:14:22 -0000
Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.apache.org>
List-Post: <mailto:dev@apex.apache.org>
List-Id: <dev.apex.apache.org>
Reply-To: dev@apex.apache.org
Delivered-To: mailing list dev@apex.apache.org
Received: (qmail 77040 invoked by uid 99); 3 Jun 2016 23:14:22 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 23:14:22 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2C81B1A01B5
	for <dev@apex.apache.org>; Fri,  3 Jun 2016 23:14:22 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id zk2g9JVhB0Ac for <dev@apex.apache.org>;
	Fri,  3 Jun 2016 23:14:20 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 67D555F2C3
	for <dev@apex.incubator.apache.org>; Fri,  3 Jun 2016 23:14:19 +0000 (UTC)
Received: (qmail 77017 invoked by uid 99); 3 Jun 2016 23:14:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 23:14:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 7E7B5DFC8C; Fri,  3 Jun 2016 23:14:18 +0000 (UTC)
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-339-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-339-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request #339: APEXCORE-466 #resolve improved loggin...
Content-Type: text/plain
Message-Id: <20160603231418.7E7B5DFC8C@git1-us-west.apache.org>
Date: Fri,  3 Jun 2016 23:14:18 +0000 (UTC)
archived-at: Fri, 03 Jun 2016 23:14:24 -0000

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/339#discussion_r65788854
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/RecordingsAgent.java ---
    @@ -640,7 +640,7 @@ public JSONObject process(WebResource.Builder webResource, Class<JSONObject> cla
               }
           );
         } catch (Exception ex) {
    -      LOG.error("Exception caught", ex);
    +      LOG.error("Cannot start recording: ", ex);
    --- End diff --
    
    @davidyan74 : Should logging be not done at same levels? I see here it is "error" and earlier it is done at "warn" and also this will print stacktrace but log messages at 546 line won't...
    
    Any reason for inconsistent log levels?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---