Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: chaithu14 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-300-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-300-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2103 Fixed the scanner issue ...
Content-Type: text/plain
Message-Id: <20160601051940.9A0F9DFB74@git1-us-west.apache.org>
Date: Wed,  1 Jun 2016 05:19:40 +0000 (UTC)
archived-at: Wed, 01 Jun 2016 05:19:46 -0000

Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r65303185
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -375,11 +374,18 @@ public void run()
                 lastScannedInfo = null;
                 numDiscoveredPerIteration = 0;
                 for (String afile : files) {
    -              String filePath = new File(afile).getAbsolutePath();
    -              LOG.debug("Scan started for input {}", filePath);
    -              Map<String, Long> lastModifiedTimesForInputDir;
    -              lastModifiedTimesForInputDir = referenceTimes.get(filePath);
    -              scan(new Path(afile), null, lastModifiedTimesForInputDir);
    +              Path filePath = new Path(afile);
    +              LOG.debug("Scan started for input {}", filePath.toString());
    +              Map<String, Long> lastModifiedTimesForInputDir = null;
    +              if (fs.exists(filePath)) {
    +                FileStatus fileStatus = fs.getFileStatus(filePath);
    +                if (fileStatus.isDirectory()) {
    +                  lastModifiedTimesForInputDir = referenceTimes.get(fileStatus.getPath().toString());
    +                } else {
    +                  lastModifiedTimesForInputDir = referenceTimes.get(fileStatus.getPath().getParent().toString());
    --- End diff --
    
    @Priyanka: If we maintain 2 different keys, then fileSplitter will emit multiple filemetadata's for /home/myDir/file1.txt. Is it expected behavior. Please correct it, if I am wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---