apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-470) New Api for setting the attribute on the operator ( setOperatorAttribute )
Date Tue, 14 Jun 2016 22:15:30 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330747#comment-15330747
] 

ASF GitHub Bot commented on APEXCORE-470:
-----------------------------------------

Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/349#discussion_r67067785
  
    --- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
    @@ -236,11 +236,22 @@
       public abstract <T> void setAttribute(Attribute<T> key, T value);
     
       /**
    -   * <p>setAttribute.</p>
    +   *
    +   * Use {@link #setOperatorAttribute} instead
        */
    +  @Deprecated
       public abstract <T> void setAttribute(Operator operator, Attribute<T> key,
T value);
     
       /**
    +   * Set an attribute on the operator.
    --- End diff --
    
    for an operator


> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --------------------------------------------------------------------------
>
>                 Key: APEXCORE-470
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-470
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Sandesh
>            Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2 Attribute setting
APIs are specific to input ports (*setInputPortAttributes*) and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate that user
wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute<T> key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (  setAttribute(Operator
operator, Attribute<T> key, T value) - can be deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator 
> All the unit test cases using the previous API will be renamed as a part of this change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message