apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-466) Improve logging from the *Agent.java files
Date Fri, 03 Jun 2016 23:14:59 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315082#comment-15315082
] 

ASF GitHub Bot commented on APEXCORE-466:
-----------------------------------------

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/339#discussion_r65788854
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/RecordingsAgent.java ---
    @@ -640,7 +640,7 @@ public JSONObject process(WebResource.Builder webResource, Class<JSONObject>
cla
               }
           );
         } catch (Exception ex) {
    -      LOG.error("Exception caught", ex);
    +      LOG.error("Cannot start recording: ", ex);
    --- End diff --
    
    @davidyan74 : Should logging be not done at same levels? I see here it is "error" and
earlier it is done at "warn" and also this will print stacktrace but log messages at 546 line
won't...
    
    Any reason for inconsistent log levels?


> Improve logging from the *Agent.java files
> ------------------------------------------
>
>                 Key: APEXCORE-466
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-466
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: David Yan
>            Assignee: David Yan
>
> Currently we are getting stack traces logging that actually do not necessarily indicate
an error.  For example: 
> {code}
> 2016-05-20 11:56:22,859 WARN com.datatorrent.stram.client.EventsAgent: Got exception
when reading events
> java.io.FileNotFoundException: File does not exist: /user/david/datatorrent/apps/application_1462948052533_0204/events/index.txt
>         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:66)
>         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:56)
>         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsUpdateTimes(FSNamesystem.java:1932)
>         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInt(FSNamesystem.java:1873)
>         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1853)
>         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1825)
>         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:559)
>         at org.apache.hadoop.hdfs.server.namenode.AuthorizationProviderProxyClientProtocol.getBlockLocations(AuthorizationProviderProxyClientProtocol.j
> ava:87)
>         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorP
> B.java:363)
>         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.
> java)
>         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:619)
>         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1060)
>         at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2044)
>         at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2040)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:415)
>         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1671)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2038)
> {code}
> This stack trace only indicates that no events have been logged yet for the application.
> We need to reduce this kind of logging to prevent false alarms to the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message