apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay M Pujare (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup
Date Thu, 30 Jun 2016 23:47:10 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358061#comment-15358061
] 

Sanjay M Pujare commented on APEXMALHAR-2069:
---------------------------------------------

> IMO, it is safer to create new execution service each time setup is called and possibly
assert or throw RuntimeException if scanService is not null to avoid misusage in unit tests.

That's a simple fix, but then we'll have to redesign or recreate Idempotency related unit
tests in FileSplitterInputTest and I would like to weigh the trade-offs of making this change.

> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization
from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2069
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>
> For example, there is no need for scanService to be initialized in the constructor. It
should be done during operator setup().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message