apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay M Pujare (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup
Date Thu, 30 Jun 2016 17:33:10 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357517#comment-15357517
] 

Sanjay M Pujare commented on APEXMALHAR-2069:
---------------------------------------------

Without the null check I get the following failure:

  FileSplitterInputTest.testFirstWindowAfterRecovery:369 Files expected:<1> but was:<2>

I implicitly assumed the unit test is trying to enforce a contract that was violated by my
earlier change so I made this change. I'll track this down and see if the unit test is in
fact "misusing" anything and needs to be fixed. Also the unit test has some dependency issues
since running it in isolation makes it pass.

> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization
from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2069
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>
> For example, there is no need for scanService to be initialized in the constructor. It
should be done during operator setup().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message