apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2045) Add bandwidth control feature to Apex
Date Thu, 23 Jun 2016 06:13:16 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345850#comment-15345850
] 

ASF GitHub Bot commented on APEXMALHAR-2045:
--------------------------------------------

Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/279#discussion_r68180270
  
    --- Diff: library/src/main/java/com/datatorrent/lib/bandwidth/BandwidthPartitioner.java
---
    @@ -0,0 +1,78 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.bandwidth;
    +
    +import java.util.Collection;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.datatorrent.common.partitioner.StatelessPartitioner;
    +
    +public class BandwidthPartitioner<T extends BandwidthLimitingOperator> extends
StatelessPartitioner<T>
    +{
    +  private static final long serialVersionUID = -7502505996637650237L;
    +  private static final Logger LOG = LoggerFactory.getLogger(BandwidthPartitioner.class);
    +
    +  /**
    +   * This creates a partitioner which creates only one partition.
    +   */
    +  public BandwidthPartitioner()
    +  {
    +  }
    +
    +  /**
    +   * This constructor is used to create the partitioner from a property.
    +   * 
    +   * @param value A string which is an integer of the number of partitions to create
    +   */
    +  public BandwidthPartitioner(String value)
    +  {
    +    super(value);
    +  }
    +
    +  /**
    +   * This creates a partitioner which creates partitonCount partitions.
    +   * 
    +   * @param partitionCount The number of partitions to create.
    +   */
    +  public BandwidthPartitioner(int partitionCount)
    +  {
    +    super(partitionCount);
    +  }
    +
    +  @Override
    +  public Collection<Partition<T>> definePartitions(Collection<Partition<T>>
partitions, PartitioningContext context)
    +  {
    +    long currentBandwidth = partitions.iterator().next().getPartitionedInstance().getBandwidthManager().getBandwidth()
    +        * partitions.size();
    +    Collection<Partition<T>> newpartitions = super.definePartitions(partitions,
context);
    +    return updateBandwidth(newpartitions, currentBandwidth);
    +  }
    +
    +  public Collection<Partition<T>> updateBandwidth(Collection<Partition<T>>
newpartitions, long currentBandwidth)
    +  {
    +    LOG.info("Updating bandwidth of partitions.");
    --- End diff --
    
    Updating message to add new bandwidth value. This will be useful when operator undergoes
partitioning and the bandwidth value is updated.


> Add bandwidth control feature to Apex
> -------------------------------------
>
>                 Key: APEXMALHAR-2045
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2045
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
>  bandwidth restrictions on input operator for number of bytes to be consumed per second.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message