apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chaithu14 <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Date Mon, 27 Jun 2016 11:13:32 GMT
Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r68559252
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableByteArrayListMultimapImpl.java
---
    @@ -0,0 +1,241 @@
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import javax.annotation.Nullable;
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.utils.serde.PassThruByteArraySliceSerde;
    +import org.apache.apex.malhar.lib.utils.serde.Serde;
    +import org.apache.apex.malhar.lib.utils.serde.SerdeIntSlice;
    +import org.apache.apex.malhar.lib.utils.serde.SliceUtils;
    +
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Multimap;
    +import com.google.common.collect.Multiset;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * Created by tfarkas on 6/12/16.
    + */
    +public class SpillableByteArrayListMultimapImpl<K, V> implements Spillable.SpillableByteArrayListMultimap<K,
V>,
    +    Spillable.SpillableComponent
    +{
    +  public static final int DEFAULT_BATCH_SIZE = 1000;
    +  public static final byte[] SIZE_KEY_SUFFIX = new byte[]{(byte)0, (byte)0, (byte)0};
    +
    +  private int batchSize = DEFAULT_BATCH_SIZE;
    +
    +  private WindowBoundedMapCache<K, SpillableArrayListImpl<V>> cache = new
WindowBoundedMapCache<>();
    +
    +  @NotNull
    +  private SpillableByteMapImpl<byte[], Integer> map;
    +
    +  private SpillableStateStore store;
    +  private byte[] identifier;
    +  private long bucket;
    +  private Serde<K, Slice> serdeKey;
    +  private Serde<V, Slice> serdeValue;
    +
    +  public SpillableByteArrayListMultimapImpl(SpillableStateStore store, byte[] identifier,
long bucket,
    +      Serde<K, Slice> serdeKey,
    +      Serde<V, Slice> serdeValue)
    +  {
    +    this.store = Preconditions.checkNotNull(store);
    +    this.identifier = Preconditions.checkNotNull(identifier);
    +    this.bucket = bucket;
    +    this.serdeKey = Preconditions.checkNotNull(serdeKey);
    +    this.serdeValue = Preconditions.checkNotNull(serdeValue);
    +
    +    map = new SpillableByteMapImpl(store, identifier, bucket, new PassThruByteArraySliceSerde(),
new SerdeIntSlice());
    +  }
    +
    +  @Override
    +  public List<V> get(@Nullable K key)
    +  {
    +    return getHelper(key);
    +  }
    +
    +  private SpillableArrayListImpl<V> getHelper(@Nullable K key)
    +  {
    +    SpillableArrayListImpl<V> spillableArrayList = cache.get(key);
    +
    +    if (spillableArrayList == null) {
    +      Slice keyPrefix = serdeKey.serialize(key);
    +      Integer size = map.get(SliceUtils.concatenate(keyPrefix, SIZE_KEY_SUFFIX));
    +
    +      if (size == null) {
    +        return null;
    +      }
    +
    +      spillableArrayList = new SpillableArrayListImpl<V>(bucket, keyPrefix.buffer,
store, serdeValue);
    +      spillableArrayList.setSize(size);
    +
    +      cache.put(key, spillableArrayList);
    +    }
    +
    +    return spillableArrayList;
    +  }
    +
    +  @Override
    +  public Set<K> keySet()
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public Multiset<K> keys()
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public Collection<V> values()
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public Collection<Map.Entry<K, V>> entries()
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public List<V> removeAll(@Nullable Object key)
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public void clear()
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public int size()
    +  {
    +    return map.size();
    +  }
    +
    +  @Override
    +  public boolean isEmpty()
    +  {
    +    return map.isEmpty();
    +  }
    +
    +  @Override
    +  public boolean containsKey(@Nullable Object key)
    +  {
    +    return map.containsKey(SliceUtils.concatenate(serdeKey.serialize((K)key), SIZE_KEY_SUFFIX));
    +  }
    +
    +  @Override
    +  public boolean containsValue(@Nullable Object value)
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public boolean containsEntry(@Nullable Object key, @Nullable Object value)
    +  {
    +    throw new UnsupportedOperationException();
    +  }
    +
    +  @Override
    +  public boolean put(@Nullable K key, @Nullable V value)
    +  {
    +    SpillableArrayListImpl<V> spillableArrayList = getHelper(key);
    +
    +    if (spillableArrayList == null) {
    +      spillableArrayList = new SpillableArrayListImpl<V>(bucket, serdeKey.serialize(key).buffer,
store, serdeValue);
    +
    +      cache.put(key, spillableArrayList);
    +    }
    +
    +    spillableArrayList.add(value);
    --- End diff --
    
    I think, map update also be in put(), otherwise, size will change only at endWindow().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message