apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandeshh <...@git.apache.org>
Subject [GitHub] apex-core pull request #350: APEXCORE-222 Purging the stale data present in ...
Date Sat, 25 Jun 2016 21:05:00 GMT
Github user sandeshh commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r68493910
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -769,7 +769,11 @@ public void processHeartbeatResponse(ContainerHeartbeatResponse rsp)
         }
     
         if (rsp.committedWindowId != lastCommittedWindowId) {
    +
           lastCommittedWindowId = rsp.committedWindowId;
    +
    +      bufferServer.purge(lastCommittedWindowId);
    --- End diff --
    
    Working on that, here are the current finding.
    
    1. Previous purge kept one extra window before the committed window. 
    2. Couldn't find the history for that in GitHub. That change is present atleast from 2013.
    
    Next steps
    
    Will conduct few test scenario to see why we need a window before the committed window
in the buffer server.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message