apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DT-Priyanka <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #279: APEXMALHAR-2045: Adding bandwidth control fea...
Date Thu, 23 Jun 2016 06:27:32 GMT
Github user DT-Priyanka commented on a diff in the pull request:

    --- Diff: library/src/test/java/com/datatorrent/lib/bandwidth/BandwidthManagerTest.java
    @@ -0,0 +1,150 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.bandwidth;
    +import java.io.File;
    +import java.io.IOException;
    +import org.junit.Assert;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TestWatcher;
    +import org.junit.runner.Description;
    +import org.apache.commons.io.FileUtils;
    +import com.datatorrent.api.Attribute;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DAG;
    +import com.datatorrent.lib.helper.OperatorContextTestHelper;
    +public class BandwidthManagerTest
    +  private static class TestMeta extends TestWatcher
    +  {
    +    private String applicationPath;
    +    private BandwidthManager underTest;
    +    private Context.OperatorContext context;
    +    private long bandwidthLimit = 10L;
    +    private ScheduledExecutorTestService mockschedular;
    --- End diff --
    I guess it will be more readable if we keep it as indipendent class as size of class is
pretty big. Also it is accessed from withing private class, so I am moving it at "default"
access level in same file.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message