apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhupeshchawda <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #295: APEXMALHAR-1966: Update cassandra output opre...
Date Thu, 23 Jun 2016 06:14:05 GMT
Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/295#discussion_r68180348
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/cassandra/AbstractCassandraTransactionableOutputOperator.java
---
    @@ -48,29 +54,58 @@
      * @param <T>type of tuple</T>
      * @since 1.0.2
      */
    -public abstract class AbstractCassandraTransactionableOutputOperator<T> extends
AbstractBatchTransactionableStoreOutputOperator<T, CassandraTransactionalStore> {
    +public abstract class AbstractCassandraTransactionableOutputOperator<T> extends
AbstractBatchTransactionableStoreOutputOperator<T, CassandraTransactionalStore> implements
ActivationListener<Context.OperatorContext>
    +{
    +  private transient PreparedStatement updateCommand;
     
    -  public AbstractCassandraTransactionableOutputOperator(){
    -    super();
    +  @Override
    +  public void activate(OperatorContext context)
    +  {
    +    updateCommand = getUpdateCommand();
       }
     
       /**
    +   * Gets the statement which insert/update the table in the database.
    +   *
    +   * @return the cql statement to update a tuple in the database.
    +   */
    +  @Nonnull
    +  protected abstract PreparedStatement getUpdateCommand();
    +
    +  /**
        * Sets the parameter of the insert/update statement with values from the tuple.
        *
        * @param tuple     tuple
        * @return statement The statement to execute
        * @throws DriverException
    +   *
    +   * @deprecated since 3.5.0.0 use {@link #setStatementParameters(PreparedStatement,
T)} instead.<br/>
        */
    +  @Deprecated
       protected abstract Statement getUpdateStatement(T tuple) throws DriverException;
    --- End diff --
    
    Will removing this cause any issues with backward compatibility. Keeping this (even deprecated)
may require us to ensure that calls to ```getUpdateStatement()``` are successful.
    @PramodSSImmaneni What is the right way to get rid of this method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message