apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PramodSSImmaneni <...@git.apache.org>
Subject [GitHub] apex-core pull request #350: APEXCORE-222 Purging the stale data present in ...
Date Tue, 14 Jun 2016 22:10:45 GMT
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/350#discussion_r67067166
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -769,7 +769,11 @@ public void processHeartbeatResponse(ContainerHeartbeatResponse rsp)
         }
     
         if (rsp.committedWindowId != lastCommittedWindowId) {
    +
           lastCommittedWindowId = rsp.committedWindowId;
    +
    +      bufferServer.purge(lastCommittedWindowId);
    --- End diff --
    
    Today there is flexibility for the server to not be in the same process even though it
is not being exercised. With this change that flexibility will be gone. How about providing
both options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message